Re: [PATCH][AArch64] Implement new intrinsics vabsd_s64 and vnegd_s64

[Sudakshina Das <sudi dot das at arm dot com>]

Hi Vlad


On Friday 20 July 2018 10:37 AM, Vlad Lazar wrote:
> Hi,
>
> The patch adds implementations for the NEON intrinsics vabsd_s64 and 
> vnegd_s64.
> (https://developer.arm.com/products/architecture/cpu-architecture/a-profile/docs/ihi0073/latest/arm-neon-intrinsics-reference-architecture-specification) 
>
>
> Bootstrapped and regtested on aarch64-none-linux-gnu and there are no 
> regressions.
>
> OK for trunk?

Thanks for doing this. This looks good to me but you will a maintainer's 
approval.

Thanks
Sudi
> Thanks,
> Vlad
>
> gcc/
> 2018-07-02  Vlad Lazar  <vlad.lazar@arm.com>
>
>     * config/aarch64/arm_neon.h (vabsd_s64, vnegd_s64): New.
>
> gcc/testsuite/
> 2018-07-02  Vlad Lazar  <vlad.lazar@arm.com>
>
>     * gcc.target/aarch64/scalar_intrinsics.c (test_vabsd_s64, 
> test_vabsd_s64): New.
>
> ---
>
> diff --git a/gcc/config/aarch64/arm_neon.h 
> b/gcc/config/aarch64/arm_neon.h
> index 
> 2d18400040f031dfcdaf60269ad484647804e1be..19e22431a85bcd09d0ea759b42b0a52420b6c43c 
> 100644
> --- a/gcc/config/aarch64/arm_neon.h
> +++ b/gcc/config/aarch64/arm_neon.h
> @@ -11822,6 +11822,13 @@ vabsq_s64 (int64x2_t __a)
>    return __builtin_aarch64_absv2di (__a);
>  }
>
> +__extension__ extern __inline int64_t
> +__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> +vabsd_s64 (int64_t __a)
> +{
> +  return __builtin_aarch64_absdi (__a);
> +}
> +
>  /* vadd */
>
>  __extension__ extern __inline int64_t
> @@ -22907,6 +22914,12 @@ vneg_s64 (int64x1_t __a)
>    return -__a;
>  }
>
> +__extension__ extern __inline int64_t
> +__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> +vnegd_s64 (int64_t __a)
> +{
> +  return -__a;
> +}
>  __extension__ extern __inline float32x4_t
>  __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
>  vnegq_f32 (float32x4_t __a)
> diff --git a/gcc/testsuite/gcc.target/aarch64/scalar_intrinsics.c 
> b/gcc/testsuite/gcc.target/aarch64/scalar_intrinsics.c
> index 
> ea29066e369b967d0781d31c8a5208bda9e4f685..45afeec373971838e0cd107038b4aa51a2d4998f 
> 100644
> --- a/gcc/testsuite/gcc.target/aarch64/scalar_intrinsics.c
> +++ b/gcc/testsuite/gcc.target/aarch64/scalar_intrinsics.c
> @@ -603,6 +603,14 @@ test_vsqaddd_u64 (uint64_t a, int64_t b)
>    return vsqaddd_u64 (a, b);
>  }
>
> +/* { dg-final { scan-assembler-times "\\tabs\\td\[0-9\]+" 1 } } */
> +
> +int64_t
> +test_vabsd_s64 (int64_t a)
> +{
> +  return vabsd_s64 (a);
> +}
> +
>  /* { dg-final { scan-assembler-times "\\tsqabs\\tb\[0-9\]+" 1 } } */
>
>  int8_t
> @@ -627,6 +635,14 @@ test_vqabss_s32 (int32_t a)
>    return vqabss_s32 (a);
>  }
>
> +/* { dg-final { scan-assembler-times "\\tneg\\tx\[0-9\]+" 1 } } */
> +
> +int64_t
> +test_vnegd_s64 (int64_t a)
> +{
> +  return vnegd_s64 (a);
> +}
> +
>  /* { dg-final { scan-assembler-times "\\tsqneg\\tb\[0-9\]+" 1 } } */
>
>  int8_t