This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][Middle-end][version 2]change char type to unsigned char type when expanding strcmp/strncmp


the patch was committed as:

https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=262907 <https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=262907>

thanks.

Qing
> On Jul 20, 2018, at 9:59 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> 
> On Fri, Jul 20, 2018 at 09:53:24AM -0500, Qing Zhao wrote:
>> +2018-07-20  Qing Zhao  <qing.zhao@oracle.com>
>> +
>> +       * builtins.c (expand_builtin_memcmp): Delete the last parameter for
>> +       call to inline_expand_builtin_string_cmp.
>> +       (expand_builtin_strcmp): Likewise.
>> +       (expand_builtin_strncmp): Likewise.
>> +       (inline_string_cmp): Delete the last parameter, change char_type_node
>> +       to unsigned_char_type_node for strcmp/strncmp, add conversions to the
>> +       two operands.
>> +       (inline_expand_builtin_string_cmp): Delete the last parameter, give up
>> +       the inlining expansion on target where the type of the call has same or 
>> +       narrower presicion than unsigned char.
> 
> s/presicion/precision/
> 
> Also in the patch, where there is another typo, s/of/or/.
> 
> Ok for trunk with that fixed.
> 
> 	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]