This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Show valid options for -march and -mtune in --help=target for arm32 (PR driver/83193).


Hi Martin,

Why is this needed when -mfpu does not seem to need it for instance?
Regarding the patch:

> -    print "Name(processor_type) Type(enum processor_type)"
> -    print "Known ARM CPUs (for use with the -mcpu= and -mtune= options):\n"
> +    print "Name(processor_type) Type(enum processor_type) ForceHelp"
> +    print "Known ARM CPUs (for use with the -mtune= options):\n"

Why changing the text beyond adding ForceHelp?

> +@item ForceHelp
> +This property is optional.  If present, enum values is printed
> +in @option{--help} output.
> +

are printed

Thanks,

Thomas
On Wed, 18 Jul 2018 at 16:50, Martin Liška <mliska@suse.cz> wrote:
>
> Hi.
>
> This introduces new ForceHelp option flag that helps to
> print valid option enum values that are not directly
> used as a type of an option.
>
> May I please ask ARM folks to test the patch?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> 2018-07-18  Martin Liska  <mliska@suse.cz>
>
>         PR driver/83193
>         * config/arm/arm-tables.opt: Add ForceHelp flag for
>         processor_type and arch_name enum types.
>         * config/arm/parsecpu.awk: Likewise.
>         * doc/options.texi: Document new flag ForceHelp.
>         * opt-read.awk: Parse ForceHelp and set it in construction.
>         * optc-gen.awk: Likewise.
>         * opts.c (print_filtered_help): Handle force_help option.
>         * opts.h (struct cl_enum): New field force_help.
> ---
>  gcc/config/arm/arm-tables.opt | 6 +++---
>  gcc/config/arm/parsecpu.awk   | 6 +++---
>  gcc/doc/options.texi          | 4 ++++
>  gcc/opt-read.awk              | 3 +++
>  gcc/optc-gen.awk              | 3 ++-
>  gcc/opts.c                    | 3 ++-
>  gcc/opts.h                    | 3 +++
>  7 files changed, 20 insertions(+), 8 deletions(-)
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]