This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions


On Tue, Jul 17, 2018 at 2:36 PM Janus Weil <janus@gcc.gnu.org> wrote:
>
> 2018-07-17 19:34 GMT+02:00 Thomas Koenig <tkoenig@netcologne.de>:
> > Am 17.07.2018 um 19:19 schrieb Janus Weil:
[...]
>
> I do hope that things have converged by now and that this will be the
> last incarnation of the patch. If there is no more feedback in the
> next 24 hours, I'll commit this tomorrow.
>
> Cheers,
> Janus

I hate to be pedantic but it is still worth fixing the style discrepancies:

$ ./contrib/check_GNU_style.sh pr85599_v7.diff
>
> Lines should not exceed 80 characters.
> 209:+      if (f != last && !gfc_pure_function (f, &name) && !gfc_implicit_pure_function (f))
>
> Blocks of 8 spaces should be replaced with tabs.
> 37:+         gfc_warning (OPT_Wfunction_elimination,
> 41:+         gfc_warning (OPT_Wfunction_elimination,
> 238:+             with impure function as second operand.  */
>
> Dot, space, space, new sentence.
> 84:+expression, if they do not contribute to the final result. For logical
> 87:+result of the expression can be established without them. However, since not

My only other comment is I am not sure why you make
pure_function()/gfc_implicit_pure_function() public... but I have no
real problem with it. Just means rebuilding all of f951 instead of one
object. :-(
Otherwise if the patch does what it appears to do and passes tests
then it seems fine to me.

Fritz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]