This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions

From: Thomas Koenig <tkoenig at netcologne dot de>
To: Janus Weil <janus at gcc dot gnu dot org>
Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 16 Jul 2018 21:50:54 +0200
Subject: Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
References: <CAKwh3qgbSjoVqRS9s-fYB8ODrBXvDV4ePoT-8E02LDn-JXxQ8g@mail.gmail.com> <CAKwh3qi91EW-ZQqsbwiFimTfWAwqX+HkB588UjWc7iavrkvvpQ@mail.gmail.com> <CAKwh3qjoLg74dL8RUvjBEuwQp=SKi8yof-W_7jDcEd6dKasyEg@mail.gmail.com> <CAKwh3qh+zKfh8NK40BuGORL=gHN+hFYVhKva0ny1t4bGX0pU3g@mail.gmail.com> <de6df17d-d374-efb3-29cc-4561226239d1@netcologne.de> <CAKwh3qi=6fub8oD77YegatnrwrtXfKqZ6WPsqKMRnMtm3ohVQQ@mail.gmail.com>

Am 16.07.2018 um 10:06 schrieb Janus Weil:

However, one point: I think that the warning should be under a separate
warning, which should then be enabled by -Wextra.
-Waggressive-function-elimination, could be reused for this,
or something else

I don't actually see such a flag in the manual.


Ah, sorry, I misremembered the option, it is actually
-Wfunction-elimination.

What I would suggest is to enable -Wfunction-eliminiation with
-Wextra and also use that for your new warning.

(I would also suggest to enable -faggressive-function-elimination
at least for -Ofast, but that is another matter).

Regards

	Thomas

Follow-Ups:
- Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
  - From: Janus Weil

References:
- [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
  - From: Janus Weil
- Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
  - From: Janus Weil
- Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
  - From: Janus Weil
- Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
  - From: Janus Weil
- Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
  - From: Thomas Koenig
- Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
  - From: Janus Weil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]