This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR86452


On 07/11/2018 07:11 AM, Richard Biener wrote:
> 
> The following fixes PR86452 by using scope_die_for which correctly
> deals with -g1 in not creating (new) DIEs for namespaces.  With
> a larger LTO testcase we run into this with a namespace DIE not
> readily available but I'm not sure the issue isn't latent with
> non-LTO.
> 
> The original code was added with the fix for PR44188 which
> had a lengthy discussion and various patch variants but this
> very piece of change didn't have an explanation and why it
> didn't use scope_die_for.  The single testcase added still passes
> after the patch.
> 
> Bootstraped on x86_64-unknown-linux-gnu, testing in progress.
> 
> OK for trunk?
> 
> Thanks,
> Richard.
> 
> 2018-07-11  Richard Biener  <rguenther@suse.de>
> 
> 	PR debug/86452
> 	* dwarf2out.c (gen_type_die_with_usage): Use scope_die_for
> 	instead of get_context_die.
OK.
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]