This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH] PR c++/79133


Hi,

On 07/07/2018 01:50, Ville Voutilainen wrote:
+	    error_at (DECL_SOURCE_LOCATION (parms),
+		      "capture %qE and lambda parameter %qE "
+		      "have the same name",
+		      cap, parms);
Should we really print the same name twice? Looks like we don't have available (yet) a location for cap - that would likely enable fancy things - but in that case too I don't think the user would find that interesting seeing the same name twice. Also, we are using %E, thus we are pretty printing expressions - which in general we don't want to do - I see that in the case of cap it gives pretty obfuscated results for the last two tests (what the heck is __lambda3?!?). So, all in all, maybe print the name once, as parms, or something like that, for the time being? Or try to avoid %E altogether?

Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]