This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] add support for --disable-gcov


Hi Jeff,

>> So add an option for disabling build and install of libgcov and the
>> related host tools.
>> 
>> 2018-06-10  Rasmus Villemoes  <rasmus.villemoes@prevas.dk>
>> 
>> gcc/
>> 	* configure.ac: Add --disable-gcov option.
>> 	* configure: Regenerate.
>> 	* Makefile.in: Honour @enable_gcov@.
>> 	* doc/install.texi: Document --disable-gcov.
>> 
>> libgcc/
>> 	* configure.ac: Add --disable-gcov option.
>> 	* configure: Regenerate.
>> 	* Makefile.in: Honour @enable_gcov@.
> OK.  Presumably you're going through the process to get write access.
> Once that's wrapped up you can install this patch.

this patch badly broke all -fprofile-generate/-fprofile-use tests in the
default case like this:

UNRESOLVED: g++.dg/bprob/g++-bprob-1.C compilation,  -O0  -fbranch-probabilities
FAIL: g++.dg/bprob/g++-bprob-1.C compilation,  -O0  -fprofile-arcs

ld: fatal: library -lgcov: not found
collect2: error: ld returned 1 exit status
compiler exited with status 1
FAIL: g++.dg/bprob/g++-bprob-1.C compilation,  -g  -fprofile-arcs

libgcov.a is not copied over from libgcc to gcc due to a typo in
libgcc/Makefile.in.  Fixed as follows; will install as obvious once
bootstrap has finished.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2018-06-27  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* Makefile.in (install_leaf): Use enable_gcov instead of
	enable_libgcov.

# HG changeset patch
# Parent  5c87d0c29765b05d7da38622b0c67a4931fe47ce
Fix typo in Makefile.in

diff --git a/libgcc/Makefile.in b/libgcc/Makefile.in
--- a/libgcc/Makefile.in
+++ b/libgcc/Makefile.in
@@ -1168,7 +1168,7 @@ install-leaf: $(install-shared) $(instal
 	$(INSTALL_DATA) libgcc.a $(DESTDIR)$(inst_libdir)/
 	chmod 644 $(DESTDIR)$(inst_libdir)/libgcc.a
 	$(RANLIB) $(DESTDIR)$(inst_libdir)/libgcc.a
-ifeq ($(enable_libgcov),yes)
+ifeq ($(enable_gcov),yes)
 	$(INSTALL_DATA) libgcov.a $(DESTDIR)$(inst_libdir)/
 	chmod 644 $(DESTDIR)$(inst_libdir)/libgcov.a
 	$(RANLIB) $(DESTDIR)$(inst_libdir)/libgcov.a

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]