This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AARCH64] PR target/84521 Fix frame pointer corruption with -fomit-frame-pointer with __builtin_setjmp
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: James Greenhalgh <James dot Greenhalgh at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Sudakshina Das <Sudi dot Das at arm dot com>, Jeff Law <law at redhat dot com>, nd <nd at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Wed, 27 Jun 2018 11:22:34 +0000
- Subject: Re: [PATCH][AARCH64] PR target/84521 Fix frame pointer corruption with -fomit-frame-pointer with __builtin_setjmp
- References: <4ee92fe8-3070-0129-59ad-40cbe0207822@arm.com> <16280160.Nx4lr6RsWP@polaris> <HE1PR08MB1035D51F733B3D8D767A492083480@HE1PR08MB1035.eurprd08.prod.outlook.com>,<3672268.4e9OnHKVQs@polaris>
Eric Botcazou wrote:
>> This test can easily be changed not to use optimize since it doesn't look
>> like it needs it. We really need to tests these builtins properly,
>> otherwise they will continue to fail on most targets.
>
> As far as I can see PR target/84521 has been reported only for Aarch64 so I'd
> just leave the other targets alone (and avoid propagating FUD if possible).
It's quite obvious from PR84521 that this is an issue affecting all targets.
Adding better generic tests for __builtin_setjmp can only be a good thing.
Wilco