This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 08/14] Convert IPA CP to symbol_summary.
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: marxin <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, mjambor at suse dot cz
- Date: Thu, 7 Jun 2018 14:46:17 +0200
- Subject: Re: [PATCH 08/14] Convert IPA CP to symbol_summary.
- References: <cover.1526551813.git.mliska@suse.cz> <f3b237e96de3c4dce221ed290a8bd05083341cfc.1526551813.git.mliska@suse.cz>
>
> gcc/ChangeLog:
>
> 2018-04-24 Martin Liska <mliska@suse.cz>
>
> * ipa-cp.c (ipcp_store_bits_results): Use
> ipcp_transformation_sum.
> (ipcp_store_vr_results): Likewise.
> * ipa-prop.c (ipcp_grow_transformations_if_necessary): Renamed
> to ...
> (ipcp_transformation_initialize): ... this.
> (ipa_set_node_agg_value_chain):
> (ipa_node_params_t::duplicate): Use ipcp_transformation_sum.
> (write_ipcp_transformation_info): Likewise.
> (read_ipcp_transformation_info): Likewise.
> (ipcp_update_bits): Likewise.
> (ipcp_update_vr): Likewise.
> (ipcp_transform_function): Likewise.
> * ipa-prop.h: Rename ipcp_transformation_summary to
> ipcp_transformation.
> (class ipcp_transformation_t): New function summary.
> (ipcp_get_transformation_summary): Use ipcp_transformation_sum.
> (ipa_get_agg_replacements_for_node): Likewise.
I will delegate this one to Martin Jambor. it looks fine to me in general except again
I would like to use get() on places we do not create new info.
Honza