This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] Improve TRUTH_{AND,OR}IF_EXPR expansion (PR rtl-optimization/78200)
- From: "Kumar, Venkataramanan" <Venkataramanan dot Kumar at amd dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Richard Biener <rguenther at suse dot de>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 27 Mar 2018 11:25:54 +0000
- Subject: RE: [PATCH] Improve TRUTH_{AND,OR}IF_EXPR expansion (PR rtl-optimization/78200)
- References: <20180327091023.GW8577@tucnak> <CY4PR12MB1736779C2772272BBAD5FDF38FAC0@CY4PR12MB1736.namprd12.prod.outlook.com> <20180327111240.GZ8577@tucnak>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Hi Jakub,
> -----Original Message-----
> From: Jakub Jelinek <jakub@redhat.com>
> Sent: Tuesday, March 27, 2018 4:43 PM
> To: Kumar, Venkataramanan <Venkataramanan.Kumar@amd.com>
> Cc: Richard Biener <rguenther@suse.de>; gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] Improve TRUTH_{AND,OR}IF_EXPR expansion (PR rtl-
> optimization/78200)
>
> On Tue, Mar 27, 2018 at 11:04:35AM +0000, Kumar, Venkataramanan wrote:
> > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk
> > > if it helps for SPEC? Venkat, do you think you could benchmark it
> > > in the setup where you've measured the slowdown to see if it helps?
> > > I see the patch changes the loop:
>
> Thanks for benchmarking it.
>
> > The patch causes regression benchmark when I measured on my Ryzen
> box (>4%) .
> >
> > GCC trunk: -O3 -maxv2 -mprefer-avx128 -O3 -march=znver1
> > 429.mcf 9120 238 38.3 * 9120 227 40.2 *
> >
> > GCC patch:
> > 429.mcf 9120 251 36.3 * 9120 236 38.6 *
>
> So, has 429.mcf improved then compared to 7.x sufficiently that we can turn
> PR78200 into just [7 Regression], without adding any patch?
Yes, we can mark this PR as GCC 7 regression only.
There is another PR (84481) for 429.mcf on Zen regression against 7.x which seem to be independent of this issue.
>
> Jakub