This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR85063] Fix switch conversion in offloading functions
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: Richard Biener <rguenther at suse dot de>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 26 Mar 2018 11:13:22 +0200
- Subject: Re: [PATCH, PR85063] Fix switch conversion in offloading functions
- References: <9e02d449-0c4a-88a8-0aac-1d353d321b74@mentor.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Mar 26, 2018 at 11:05:52AM +0200, Tom de Vries wrote:
> OK for stage4 or stage1?
Ok for stage4, thanks.
Just a small nit below.
> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.c/switch-conversion-2.c
> @@ -0,0 +1,28 @@
No /* { dg-additional-options "-ftree-switch-conversion" } */
here, but:
> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.c/switch-conversion.c
> @@ -0,0 +1,35 @@
> +/* { dg-additional-options "-ftree-switch-conversion" } */
only here. Either you don't need it at all, the default
flags are -O2 I think, or use it explicitly in all the testcases, not just 2
of them. And, please add
/* PR tree-optimization/85063 */
as the first line of all those new testcases.
Jakub