This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AArch64][1/3] PR target/84164: Simplify subreg + redundant AND-immediate
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, James Greenhalgh <james dot greenhalgh at arm dot com>, richard dot sandiford at linaro dot org, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Wed, 14 Mar 2018 15:07:10 +0100
- Subject: Re: [PATCH][AArch64][1/3] PR target/84164: Simplify subreg + redundant AND-immediate
- References: <5A747F56.7020403@foss.arm.com> <b8984175-5e32-282c-665d-a9363ef421f5@arm.com> <5A748725.4020500@foss.arm.com> <03571583-e3fa-cdc4-8abe-343bb02f6ec6@arm.com> <5A7C847E.1020704@foss.arm.com> <874lmrxm17.fsf@linaro.org> <5A81B049.4070505@foss.arm.com> <5A8AB694.8010103@foss.arm.com> <5A9819EE.1050008@foss.arm.com> <0dc858e4-e31a-e8fe-247b-72c90f309c2e@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Mar 02, 2018 at 10:34:22AM -0700, Jeff Law wrote:
> >>> 2018-02-12 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
> >>>
> >>> PR target/84164
> >>> * simplify-rtx.c (simplify_truncation): Simplify truncation of
> >>> masking
> >>> operation.
> >>> * config/aarch64/aarch64.md (*aarch64_reg_<mode>3_neg_mask2):
> >>> Use simplify_gen_unary creating a SUBREG.
> >>> (*aarch64_reg_<mode>3_minus_mask): Likewise.
> >>> (*aarch64_<optab>_reg_di3_mask2): Use const_int_operand predicate
> >>> for operand 3.
> >>>
> >>> 2018-02-12 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
> >>>
> >>> PR target/84164
> >>> * gcc.c-torture/compile/pr84164.c: New test.
> Sorry. I suspect I dropped this from my inbox when it had the AArch64
> marker -- I didn't realize it had a target independent component.
>
> The simplify-rtx bits are fine. The version in simplify_truncation is
> much better than the original in simplify_subreg (which I think needed
> to verify that you were looking at the lowpart before optimizing).
Isn't that a stage1 material though? I fear given the amount of changes
that needed to be done for it on i386.md that similar amount of work would
be needed on many other targets, especially if they have less extensive
testsuite coverage it might take a while to discover it.
Jakub