This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PR84620] output symbolic entry_view as data2, not addr

On Fri, Mar 09, 2018 at 05:49:34AM -0300, Alexandre Oliva wrote:
> @@ -27699,6 +27780,9 @@ dwarf2out_source_line (unsigned int line, unsigned int column,
>  	{
>  	  if (!RESETTING_VIEW_P (table->view))
>  	    {
> +	      table->symviews_since_reset++;
> +	      if (table->symviews_since_reset > symview_upper_bound)
> +		symview_upper_bound = table->symviews_since_reset;

You could have used
	      symview_upper_bound
		= MAX (symview_upper_bound, table->symviews_since_reset);

Also, I'd say there should be
  symview_upper_bound = 0;
in dwarf2out_c_finalize for better behavior of GCC JIT.

Otherwise LGTM, but please give Jason a day to comment on.

	Jakub
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]