This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix reg-stack error-recovery ICE (PR inline-asm/84683)
- From: Jeff Law <law at redhat dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 7 Mar 2018 10:03:51 -0700
- Subject: Re: [PATCH] Fix reg-stack error-recovery ICE (PR inline-asm/84683)
- Authentication-results: sourceware.org; auth=none
- References: <20180305204251.GS5867@tucnak> <CAFULd4a623zsjnVQywjQe2DfaMMy7nZpJTP++_tEkPVO7LFLfA@mail.gmail.com>
On 03/06/2018 01:03 AM, Uros Bizjak wrote:
> On Mon, Mar 5, 2018 at 9:42 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> Hi!
>>
>> If we discover some bad inline-asm during reg-stack processing and we
>> error on those, we replace that inline-asm with a (use (const_int 0))
>> and therefore the various assumptions of reg-stack pass may not hold.
>> Seems we already have a couple of spots which are more permissive if
>> any_malformed_asm is true, this patch just adds another one.
>>
>> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>>
>> 2018-03-05 Jakub Jelinek <jakub@redhat.com>
>>
>> PR inline-asm/84683
>> * reg-stack.c (move_for_stack_reg): If any_malformed_asm, avoid
>> assertion failure.
>>
>> * g++.dg/ext/pr84683.C: New test.
>
> LGTM.
Likewise.
jeff