This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Fix PR84534: several powerpc test cases fail starting with r257915
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Bill Seurer <seurer at linux dot vnet dot ibm dot com>
- Date: Wed, 28 Feb 2018 16:36:44 -0600
- Subject: Re: [PATCH, rs6000] Fix PR84534: several powerpc test cases fail starting with r257915
- Authentication-results: sourceware.org; auth=none
- References: <593f8da7-fb69-0400-f691-dbabc32cb639@vnet.ibm.com>
Hi!
On Wed, Feb 28, 2018 at 09:39:14AM -0600, Peter Bergner wrote:
> This patch fixes PR84534 by XFAILing one test because we are deprecating
> -maltivec=be when run on LE. The other tests are fixed by not counting
> xxlor insns. We cannot rely on stable counts of xxlor insns, because we
> generate them not only when using __builtin_vec_or(), but also whenever
> we need to copy one vsx reg to another...which can vary depending on
> previous optimizations, moon phases, etc. Therefore, we just make sure
> we generate at least one. I'll note I did try adding -dp and seeing
> which patterns generated the xxlors, but there wasn't a clear match
> between the xxlor's generated because of the __builtin_vec_or and the
> reg copies.
> gcc/testsuite/
> PR target/84534
> * gcc.target/powerpc/vec-setup-be-long.c: xfail.
"Add xfail for powerpc64le" or similar?
> * gcc.target/powerpc/vsx-vector-6-le.c: Do not count xxlor's.
> * gcc.target/powerpc/vsx-vector-6-le.p9.c: Likewise.
Please add a comment to the testcase why there is no count here.
Okay for trunk with that. Thanks!
Segher