This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++] [PR84231] overload on cond_expr in template
- From: Jason Merrill <jason at redhat dot com>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 28 Feb 2018 11:51:04 -0500
- Subject: Re: [C++] [PR84231] overload on cond_expr in template
- Authentication-results: sourceware.org; auth=none
- References: <orvaf6gbhl.fsf@lxoliva.fsfla.org> <CADzB+2=8Kbj6gyr+DG4LoRxA+Cmq9OG5QGqPOJpn-18BPfcs3g@mail.gmail.com> <orefl6qpe2.fsf@lxoliva.fsfla.org> <CADzB+2=rxZcJjkK+mw7fN1Ys4Mb4UoO=8robo=R_g=XaL=b56g@mail.gmail.com> <ory3jdsn4e.fsf@lxoliva.fsfla.org>
On Wed, Feb 28, 2018 at 12:24 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
> + if (processing_template_decl)
> + result_type = cp_build_reference_type (result_type, !is_lvalue);
If !is_lvalue, we don't want a reference type at all, as the result is
a prvalue. is_lvalue should probably rename to is_glvalue.
The second argument to cp_build_reference_type should be xvalue_p (arg2).
> + /* Except for type-dependent exprs, a REFERENCE_TYPE will
> + indicate whether its result is an lvalue or so.
"or not" ?
> + if (processing_template_decl
> + && !type_dependent_expression_p (CONST_CAST_TREE (ref)))
> + return clk_none;
I think we want to return clk_class for a COND_EXPR of class type.
Can we actually get here for a type-dependent expression? I'd think
we'd never get as far as asking whether a type-dependent expression is
an lvalue, since in general we can't answer that question.
Jason