This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)
- From: Martin Sebor <msebor at gmail dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: Jason Merrill <jason at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 27 Feb 2018 16:30:37 -0700
- Subject: Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)
- Authentication-results: sourceware.org; auth=none
- References: <CAGWvnyn8ESrpta8f4PoDLBi+ED0EJ5+mEqB0QeinK3gHL0MhYA@mail.gmail.com>
On 02/27/2018 04:21 PM, David Edelsohn wrote:
Martin,
This patch broke bootstrap.
diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c
index 42fd872..9c2e5e6 100644
--- a/gcc/cp/pt.c
+++ b/gcc/cp/pt.c
@@ -24,6 +24,7 @@ along with GCC; see the file COPYING3. If not see
all methods must be provided in header files; can't use a source
file that contains only the method templates and "just win". */
+#include <string>
#include "config.h"
#include "system.h"
#include "coretypes.h"
Nothing is allowed to be included before GCC config.h and system.h.
And you should not be including C++ header files directly. If you
truly need <string>, the file should define INCLUDE_STRING (see
system.h).
Sorry, I didn't know that and my bootstrap worked. I committed
r258046 (following what gcc/ipa-chkp.c does).
Martin