This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] adjust warning_n() to take uhwi (PR 84207)


On 02/22/2018 02:15 PM, Joseph Myers wrote:
On Thu, 22 Feb 2018, Martin Sebor wrote:

Ping: https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00858.html

This is just a tweak to fix a translation bug introduced by
one of my warnings (calling warning() where warning_n() is
more appropriate), and to enhance warning_n() et al. to do
the n % 1000000 + 1000000 computation so callers don't have
to worry about it.

OK in the absence of diagnostic maintainer objections within 48 hours,
with the comment saying "ngettext()" changed to remove the "()" (see the
GNU Coding Standards: "Please do not write @samp{()} after a function name
just to indicate it is a function.  @code{foo ()} is not a function, it is
a function call with no arguments.").

Committed as r258044.

Martin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]