This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Aarch64] Fix conditional branches with target far away.
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Sameera Deshpande <sameera dot deshpande at linaro dot org>
- Cc: James Greenhalgh <james dot greenhalgh at arm dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, Richard Sandiford <richard dot sandiford at linaro dot org>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 27 Feb 2018 12:55:33 +0000
- Subject: Re: [Aarch64] Fix conditional branches with target far away.
- Authentication-results: sourceware.org; auth=none
- References: <CAAdirjy_9vvKfM38d-U64f+MPNLeR3x3-JkKWg_Erf0+LCJSAg@mail.gmail.com>
On Wed, Feb 14, 2018 at 8:30 AM, Sameera Deshpande
<sameera.deshpande@linaro.org> wrote:
> Hi!
>
> Please find attached the patch to fix bug in branches with offsets over 1MiB.
> There has been an attempt to fix this issue in commit
> 050af05b9761f1979f11c151519e7244d5becd7c
>
> However, the far_branch attribute defined in above patch used
> insn_length - which computes incorrect offset. Hence, eliminated the
> attribute completely, and computed the offset from insn_addresses
> instead.
>
> Ok for trunk?
>
> gcc/Changelog
>
> 2018-02-13 Sameera Deshpande <sameera.deshpande@linaro.org>
> * config/aarch64/aarch64.md (far_branch): Remove attribute. Eliminate
> all the dependencies on the attribute from RTL patterns.
>
I'm not a maintainer but this looks good to me modulo notes about how
this was tested. What would be nice is a testcase for the testsuite as
well as ensuring that the patch has been bootstrapped and regression
tested. AFAIR, the original patch was put in because match.pd failed
when bootstrap in another context.
regards
Ramana
> --
> - Thanks and regards,
> Sameera D.