This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH rs6000] Fix for builtins-4-runnable.c testcase FAIL on power7/BE 32-bit
Hi Carl,
On Mon, Feb 12, 2018 at 08:20:16AM -0800, Carl Love wrote:
> On Mon, 2018-02-12 at 09:17 -0600, Segher Boessenkool wrote:
> > > Without the powerpc64*-*-* the test was still tried to compiled the
> > > test case in 32-bit mode on BE and failed.
> >
> > If the dg-do target clause fails, you still get the default dg-do
> > value,
> > which is "compile" for most testcases.
> >
> > You want to use dg-require-effective-target int128 if the testcase
> > cannot compile without int128. Could you try that?
> >
> > Btw, your patch is completely whitespace-damaged which makes it very
> > hard
> > to read (and impossible to apply). Please fix your setup :-)
[ That is fixed now, thanks! ]
> No problem, I hadn't committed the patch yet. Nothing seemed to be
> going right for me last Friday so I figured it best to wait for a
> better day to do the commit.
>
> I updated the patch as requested. The dg commands are now:
>
> /* { dg-do run } */
> /* { dg-require-effective-target int128 } */
> /* { dg-require-effective-target vsx_hw } */
> /* { dg-options "-maltivec -mvsx" } */
Thanks, that looks good.
> 2018-02-12 Carl Love <cel@us.ibm.com>
>
> * gcc.target/powerpc/builtins-4-runnable.c (main): Move int128 and
You have a tab in the middle of the line there (after "Move").
> uint128 tests to new testfile.
> * gcc.target/powerpc/builtins-4-int128-runnable.c: New testfile for
> int128 and uint128 tests.
> * gcc.target/powerpc/powerpc.exp: Add builtins-4-int128-runnable.c to
> list of torture tests.
Okay for trunk. Thanks!
Segher