This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Update vsx-vector-6-le.c tests for p9 target
- From: Will Schmidt <will_schmidt at vnet dot ibm dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Wed, 07 Feb 2018 17:23:31 -0600
- Subject: Re: [PATCH, rs6000] Update vsx-vector-6-le.c tests for p9 target
- Authentication-results: sourceware.org; auth=none
- References: <1518023772.11602.268.camel@brimstone.rchland.ibm.com> <20180207182844.GG21977@gate.crashing.org>
- Reply-to: will_schmidt at vnet dot ibm dot com
On Wed, 2018-02-07 at 12:28 -0600, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Feb 07, 2018 at 11:16:12AM -0600, Will Schmidt wrote:
> > Noted during review of test results on P9. Due to changes and improvements,
> > our codegen is different for this test on power9.
> > Modified the existing test to target P8, and added a P9 variant with updated
> > counts.
>
> > diff --git a/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-le.c b/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-le.c
> > index ddb0089..7fe691b 100644
> > --- a/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-le.c
> > +++ b/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-le.c
> > @@ -1,11 +1,11 @@
> > /* { dg-do compile { target { powerpc64le-*-* && lp64 } } } */
> > /* { dg-skip-if "" { powerpc*-*-darwin* } } */
> > /* { dg-require-effective-target powerpc_vsx_ok } */
> > -/* { dg-options "-mvsx -O2" } */
> > +/* { dg-options "-mvsx -O2 -mcpu=power8" } */
>
> Why not -mcpu=power7? And you'll need
My default answer on that one is "power7 + le = nope". :-)
I can be convinced otherwise if there are strong feelings, etc.
> /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power7" } } */
>
> You could also do instead
>
> /* { dg-skip-if "this is not for p9" { powerpc_p9vector_ok } } */
>
> or something like that; a bit neater.
ok. I'll poke at this a bit, and will post (v2) for this once it's
ready.
>
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/powerpc/vsx-vector-6-le.p9.c
> > @@ -0,0 +1,32 @@
> > +/* { dg-do compile { target { powerpc64le-*-* && lp64 } } } */
> > +/* { dg-skip-if "" { powerpc*-*-darwin* } } */
> > +/* { dg-require-effective-target powerpc_p9vector_ok } */
> > +/* { dg-options "-mvsx -O2 -mcpu=power9" } */
>
> This needs the "do not override -mcpu" thing as well.
ok.
Thanks,
-Will
>
> Segher
>