This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR libgcc/59714 complex division is surprising on aarch64
On Tue, 6 Feb 2018, vladimir.mezentsev@oracle.com wrote:
> We see 'struct _FP_STRUCT_LAYOUT' is declared twice (in lines 206 and
_FP_STRUCT_LAYOUT is not a struct tag. It is a macro that may be defined
to empty, or to an attribute, and defaults to empty in soft-fp.h if not
otherwise defined in sfp-machine.h (for example, the x86 sfp-machine.h
defines it for MinGW where default struct layout would otherwise be
inappropriate).
If you're seeing it used as a struct tag, that means you're missing an
inclusion of soft-fp.h which is required to be able to include the other
soft-fp headers. But really I suspect that using soft-fp headers is a
mistake here, because of the dependence on per-machine sfp-machine.h that
should generally be irrelevant for your purposes (beyond having some way
to declare appropriate struct layouts).
> P.S.:
> gcc/libgcc/soft-fp/ and glibc/soft-fp/ are not synchronized now. For
> example:
It's not necessary to update after every change in glibc if that change is
not relevant to GCC. But if any change is required in GCC it should be
made first in glibc, and then all files updated from the versions in
glibc.
--
Joseph S. Myers
joseph@codesourcery.com