This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

libgo patch committed: Rename TestAddr6 to avoid PPC64 confusion in gotest script

From: Ian Lance Taylor <iant at golang dot org>
To: gcc-patches <gcc-patches at gcc dot gnu dot org>, gofrontend-dev at googlegroups dot com
Date: Wed, 31 Jan 2018 06:43:48 -0800
Subject: libgo patch committed: Rename TestAddr6 to avoid PPC64 confusion in gotest script
Authentication-results: sourceware.org; auth=none

This patch to libgo renames the variable TestAddr6.  The script
libgo/testsuite/gotest picks up names that start with Test to find the
test functions to run.  On most systems it only looks for functions,
but on PPC64, because of the function descriptors used for ELF ABI v1,
it also looks for data symbols.  That causes it to incorrectly think
that TestAddr6, which is a variable, is a function.  We should fix the
script properly, but, for now, rename the variable.  This fixes
https://golang.org/issue/23623.  Bootstrapped and ran Go testsuite on
x86_64-pc-linux-gnu.  Committed to mainline.

Ian

Attachment: patch.txt
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]