This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR84068: Fix sort order of SCHED_PRESSURE_MODEL
- From: Alexander Monakov <amonakov at ispras dot ru>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
- Date: Wed, 31 Jan 2018 15:16:35 +0300 (MSK)
- Subject: Re: [PATCH] PR84068: Fix sort order of SCHED_PRESSURE_MODEL
- Authentication-results: sourceware.org; auth=none
- References: <DB6PR0801MB2053A5536707256D8EF14AAB83FB0@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On Wed, 31 Jan 2018, Wilco Dijkstra wrote:
> The comparison order for SCHED_PRESSURE_MODEL is incorrect. If either
> instruction is not in target_bb, the ordering is not well defined. To fix
> this, give all instructions in target_bb the highest priority and sort all
> other instructions behind it. This way instructions in target_bb will be
> sorted using the pressure model, and instructions outside it will use
> RFS_DEP_COUNT and/or RFS_TIE for their order.
This appears to be the same issue as PR 83459; please add rtl-optimization/83459
to ChangeLog if approved.
> PR rlt-optimization/84068
> * haifa-sched.c (rank_for_schedule): Fix SCHED_PRESSURE_MODEL sorting.
>
> PR rlt-optimization/84068
Note typos in category name (s/rlt/rtl).
Alexander