This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PR lto/84105] handle TYPE_IDENTIFIERs for FUNCTION_TYPEs in the gimple pretty printer


On Tue, Jan 30, 2018 at 7:29 PM, Aldy Hernandez <aldyh@redhat.com> wrote:
> Hi!
>
> As discussed in the PR, the ICE here happens in dump_generic_node:
>
>     case FUNCTION_TYPE:
>     case METHOD_TYPE:
> ...
>       if (TYPE_NAME (node) && DECL_NAME (TYPE_NAME (node)))
>         dump_decl_name (pp, TYPE_NAME (node), flags);
>
> (gdb) print node
> $21 = <function_type 0x7fffef652dc8 printfn_t>
> (gdb) print node.type_common.name
> $22 = <identifier_node 0x7fffef654730 printfn_t>
>
> TYPE_NAME is an IDENTIFIER_NODE, whereas we're expecting a DECL_P, and bad
> things happen.
>
> OK pending tests?

OK.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]