This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][GCC][Testsuite] Have dg-cmp-results reject log files.
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org,Tamar Christina <tamar dot christina at arm dot com>
- Cc: nd at arm dot com,ro at CeBiTec dot Uni-Bielefeld dot DE,mikestump at comcast dot net
- Date: Tue, 23 Jan 2018 12:30:40 +0100
- Subject: Re: [PATCH][GCC][Testsuite] Have dg-cmp-results reject log files.
- Authentication-results: sourceware.org; auth=none
- References: <20180123103125.GA20745@arm.com>
On 23 January 2018 11:31:27 CET, Tamar Christina <tamar.christina@arm.com> wrote:
>Hi All,
>
>This patch makes dg-cmp-results.sh reject the use of log files in the
>comparison.
>Often when given a log file dg-cmp-results will give incomplete/wrong
>output and
>using log instead of sum is one autocomplete tab away.
>
>Instead have the tool guard against such mistakes.
+if test "$OEXT" = "log"; then
+ echo "<old-file> must be a sum file instead of log file."
+ exit 1
+fi
+
+if test "$NEXT" = "log"; then
+ echo "<old-file> must be a sum file instead of log file."
typo: new-file
+ exit 1
+fi
>
>Ok for trunk?
>
>Thanks,
>Tamar
>
>contrib/
>2018-01-23 Tamar Christina <tamar.christina@arm.com>
>
> * dg-cmp-results.sh: Reject log files from comparison.