This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Go patch committed: Update to Go1.10beta1
Hi Ian,
> On Thu, Jan 11, 2018 at 1:46 AM, Rainer Orth
> <ro@cebitec.uni-bielefeld.de> wrote:
>>
>>> On Wed, Jan 10, 2018 at 5:42 AM, Ian Lance Taylor <iant@golang.org> wrote:
>>>>
>>>> Whoops, there's a bug on big-endian 32-bit systems. I'm testing
>>>> https://golang.org/cl/87135.
>>>
>>> Committed as follows.
>>
>> thanks, that fixed quite a lot of the failures.
>>
>> However, many others remain, too many to report here. I've filed PR
>> go/83787 to capture those.
>
> Thanks. I found the problem: there is a new function makechan that
> takes a size argument of type int, and the old makechan, that took
> int64, is now makechan64. Since the size argument was the last one,
> this worked fine except on 32-bit big-endian systems. Fixed with this
> patch. Bootstrapped and tested on x86_64-pc-linux-gnu and
> sparc-sun-solaris2.12. Committed to mainline.
great, thanks for fixing this.
One related question: I mentioned in passing in the PR that four go test
invocations in gotools would hang indefinitely. I noticed that they
weren't called with -test.timeout, unlike libgo's gotest. However, in
exceptional cases like this this probably can't be helped short of
adding an external timeout mechanism.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University