This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] RL78 UNUSED note setting bug fix in rl78_note_reg_set
- From: DJ Delorie <dj at redhat dot com>
- To: "Sebastian Perta" <sebastian dot perta at renesas dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 12 Jan 2018 13:12:24 -0500
- Subject: Re: [PATCH] RL78 UNUSED note setting bug fix in rl78_note_reg_set
- Authentication-results: sourceware.org; auth=none
"Sebastian Perta" <sebastian.perta@renesas.com> writes:
> Please let me know if this is OK. Thank you!
Do you have checkin privs yet?
This is ok aside from..
> + /* 'dead' keeps track of the QImode registers if r is of different size
> + we need to check the other subparts as well */
Missing period at the end of a sentence; should capitalize first word
but it's a variable, which should be block caps anyway, and it reads
better as two sentences:
> + /* DEAD keeps track of the QImode registers. If R is of different size
> + we need to check the other subparts as well. */
Or rewrite to not mention variables?
> + /* Do not mark the reg unused unless all QImode parts of it are dead. */