This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Change x86 intrinsic compat headers to use #error
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Wed, 10 Jan 2018 14:23:49 -0600
- Subject: Re: [PATCH, rs6000] Change x86 intrinsic compat headers to use #error
- Authentication-results: sourceware.org; auth=none
- References: <9b827fd6-4027-d53a-6a7f-359019bf6d78@vnet.ibm.com> <20180110201418.GV21977@gate.crashing.org>
On 1/10/18 2:14 PM, Segher Boessenkool wrote:
> On Tue, Jan 09, 2018 at 04:09:25PM -0600, Peter Bergner wrote:
>> The following patch changes the x86 intrinsic compat headers to use #error
>> instead of #warning. We do this for two reasons. Firstly, we want the user
>> to really be sure they want/need to use the x86 intrinsic compat support
>> before doing so, because a warning is too easy to ignore. Secondly, we don't
>> want configure time tests that check for whether x86 intrinsic support exists
>> and then use them if they do, to automatically enable usage of them.
>> The x86 intrinsic compat support should only be used when there is no other
>> option to the user (ie, no generic or ppc specific code exists).
>>
>> Is this ok for trunk?
>
> Okay, thanks!
Committed, thanks!
Peter