This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Replying to an older patch ([PATCH] Fix failing test-case)
- From: Martin Liška <mliska at suse dot cz>
- To: Sudakshina Das <sudi dot das at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: nd <nd at arm dot com>, hubika at ucw dot cz
- Date: Tue, 19 Dec 2017 11:49:25 +0100
- Subject: Re: Replying to an older patch ([PATCH] Fix failing test-case)
- Authentication-results: sourceware.org; auth=none
- References: <a45b078e-0d23-aeec-17bb-e2fdf1dd2c92@arm.com>
On 11/30/2017 12:03 PM, Sudakshina Das wrote:
> https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01157.html
>
> This patch fixed a test case switch-case-2.c. I am seeing switch-case-1.c failing on
>
> arm-none-linux-gnueabihf:
> FAIL: gcc.dg/tree-prof/switch-case-1.c scan-rtl-dump-times expand ";; basic block[^\\n]*count 2000" 1 (found 0 times)
>
> aarch64-none-linux-gnu:
> FAIL: gcc.dg/tree-prof/switch-case-1.c scan-rtl-dump-times expand ";; basic block[^\\n]*count 2000" 1 (found 2 times)
>
> which looks pretty similar (also the same changes make it pass). Can you confirm?
>
> Sudi
Hello.
There's patch for that. Can you please test it?
Martin
>From e4570be2df2c2fd62d21bca829376670cbb96dc2 Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Tue, 19 Dec 2017 11:47:56 +0100
Subject: [PATCH] Fix another failing test-case.
gcc/testsuite/ChangeLog:
2017-12-19 Martin Liska <mliska@suse.cz>
* gcc.dg/tree-prof/switch-case-1.c: Scan IPA profile dump
file instead of expand in order to not mix it with expanded
tree decision tree for the switch statement.
---
gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c b/gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c
index 6a9af083a9a..a5a430a8ed5 100644
--- a/gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c
+++ b/gcc/testsuite/gcc.dg/tree-prof/switch-case-1.c
@@ -1,4 +1,4 @@
-/* { dg-options "-O2 -fdump-rtl-expand-all" } */
+/* { dg-options "-O2 -fdump-ipa-profile-all" } */
int g;
__attribute__((noinline)) void foo (int n)
@@ -36,5 +36,5 @@ int main ()
return 0;
}
/* autofdo cannot do that precise execution numbers */
-/* { dg-final-use-not-autofdo { scan-rtl-dump-times ";; basic block\[^\\n\]*count 4000" 2 "expand"} } */
-/* { dg-final-use-not-autofdo { scan-rtl-dump-times ";; basic block\[^\\n\]*count 2000" 1 "expand"} } */
+/* { dg-final-use-not-autofdo { scan-ipa-dump-times ";; basic block\[^\\n\]*count 4000" 2 "profile"} } */
+/* { dg-final-use-not-autofdo { scan-ipa-dump-times ";; basic block\[^\\n\]*count 2000" 1 "profile"} } */
--
2.14.3