This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c


On Tue, Dec 12, 2017 at 04:56:36PM -0500, Michael Meissner wrote:
> On Tue, Dec 12, 2017 at 11:04:55AM -0600, Segher Boessenkool wrote:
> > On Mon, Dec 11, 2017 at 03:57:51PM -0500, Michael Meissner wrote:
> > > > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype);
> > > > > +
> > > > >  KCtype
> > > > >  __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d)
> > > > >  {
> > > > 
> > > > How does this warn?  -Wmissing-declarations?  Should this declaration be
> > > > in a header then?

> As Andreas points out, the option -Wmissing-prototypes complains if a global
> function is compliled without prototypes for C/Objective C.
> 
> Before the patch, the internal definition within the compiler meant that that
> __mulkc3 would not get the warning.  Now with separate ifunc handlers, both
> __mulkc3_sw and __mulkc3_hw got warnings.

Gotcha.  There isn't a nice header file for it, so sure that is fine
the way you have it.  Thanks for the explanation!


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]