This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH branch/gimple-linterchange]Use dyn_cast instread of is_a<> and as_a<>
- From: Bin Cheng <Bin dot Cheng at arm dot com>
- To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: nd <nd at arm dot com>, "dmalcolm at redhat dot com" <dmalcolm at redhat dot com>
- Date: Fri, 1 Dec 2017 10:53:30 +0000
- Subject: [PATCH branch/gimple-linterchange]Use dyn_cast instread of is_a<> and as_a<>
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bin dot Cheng at arm dot com;
- Nodisclaimer: True
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Hi,
This is a simple patch using dyn_cast instead of is_a<> and as_a<> as suggested by review.
This is for branches/gimple-linterchange, bootstrap and test as when the branch is created. Is it OK?
Thanks,
bin
2017-11-30 Bin Cheng <bin.cheng@arm.com>
* gimple-loop-interchange.cc (is-a.h): New header file.
(loop_cand::find_reduction_by_stmt): Use dyn_cast instead of is_a<>
and as_a<>.
(loop_cand::analyze_iloop_reduction_var): Ditto.
(loop_cand::analyze_oloop_reduction_var): Ditto. Check gimple stmt
against phi node directly.
From 88ddf90ee183f2e58bb5d4b38d14733412603b44 Mon Sep 17 00:00:00 2001
From: Bin Cheng <binche01@e108451-lin.cambridge.arm.com>
Date: Wed, 29 Nov 2017 11:23:52 +0000
Subject: [PATCH 40/42] dyn_cast
---
gcc/gimple-loop-interchange.cc | 25 +++++++------------------
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git a/gcc/gimple-loop-interchange.cc b/gcc/gimple-loop-interchange.cc
index 7afafb8..e999822 100644
--- a/gcc/gimple-loop-interchange.cc
+++ b/gcc/gimple-loop-interchange.cc
@@ -22,6 +22,7 @@ along with GCC; see the file COPYING3. If not see
#include "system.h"
#include "coretypes.h"
#include "backend.h"
+#include "is-a.h"
#include "tree.h"
#include "gimple.h"
#include "tree-pass.h"
@@ -270,12 +271,9 @@ unsupported_edge (edge e)
reduction_p
loop_cand::find_reduction_by_stmt (gimple *stmt)
{
- gphi *phi = NULL;
+ gphi *phi = dyn_cast <gphi *> (stmt);
reduction_p re;
- if (is_a <gphi *> (stmt))
- phi = as_a <gphi *> (stmt);
-
for (unsigned i = 0; m_reductions.iterate (i, &re); ++i)
if ((phi != NULL && phi == re->lcssa_phi)
|| (stmt == re->producer || stmt == re->consumer))
@@ -591,10 +589,8 @@ loop_cand::analyze_iloop_reduction_var (tree var)
continue;
/* Or else it's used in PHI itself. */
- use_phi = NULL;
- if (is_a <gphi *> (stmt)
- && (use_phi = as_a <gphi *> (stmt)) != NULL
- && use_phi == phi)
+ use_phi = dyn_cast <gphi *> (stmt);
+ if (use_phi == phi)
continue;
if (use_phi != NULL
@@ -684,12 +680,7 @@ loop_cand::analyze_oloop_reduction_var (loop_cand *iloop, tree var)
if (is_gimple_debug (stmt))
continue;
- if (!flow_bb_inside_loop_p (m_loop, gimple_bb (stmt)))
- return false;
-
- if (! is_a <gphi *> (stmt)
- || (use_phi = as_a <gphi *> (stmt)) == NULL
- || use_phi != inner_re->phi)
+ if (stmt != inner_re->phi)
return false;
}
@@ -701,10 +692,8 @@ loop_cand::analyze_oloop_reduction_var (loop_cand *iloop, tree var)
continue;
/* Or else it's used in PHI itself. */
- use_phi = NULL;
- if (is_a <gphi *> (stmt)
- && (use_phi = as_a <gphi *> (stmt)) != NULL
- && use_phi == phi)
+ use_phi = dyn_cast <gphi *> (stmt);
+ if (use_phi == phi)
continue;
if (lcssa_phi == NULL
--
1.9.1