This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Make shift argument to eoshift0 be of type index_type

From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
To: Thomas Koenig <tkoenig at netcologne dot de>
Cc: Fortran List <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Wed, 22 Nov 2017 22:06:11 +0200
Subject: Re: [PATCH] Make shift argument to eoshift0 be of type index_type
Authentication-results: sourceware.org; auth=none
References: <1511350460-13820-1-git-send-email-blomqvist.janne@gmail.com> <d7d39e6d-3fe2-7851-68e9-9b8769c6a125@netcologne.de>

On Wed, Nov 22, 2017 at 8:03 PM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hi Janne,
>
>> Regtested on x86_64-pc-linux-gnu, Ok for trunk?
>>
>> libgfortran/ChangeLog:
>>
>> 2017-11-22  Janne Blomqvist<jb@gcc.gnu.org>
>>
>>         * intrinsics/eoshift0.c (eoshift0): Make shift an index_type.
>
>
> Looks good in principle. Is it possible to come up with a test case?
> This might not be executable on all systems, but it is still worth
> trying to run at least once.

I just mailed out an updated patch with a testcase in the commit msg.
I also noticed that eoshift2 suffers from the same issue, so I added a
fix for that to the patch as well (though the testcase only exercises
eoshift0).

Is that better? Ok for trunk?

-- 
Janne Blomqvist

Follow-Ups:
- Re: [PATCH] Make shift argument to eoshift0 be of type index_type
  - From: Thomas Koenig

References:
- [PATCH] Make shift argument to eoshift0 be of type index_type
  - From: Janne Blomqvist
- Re: [PATCH] Make shift argument to eoshift0 be of type index_type
  - From: Thomas Koenig

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]