This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Add support for #pragma GCC unroll
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Mike Stump <mikestump at comcast dot net>
- Date: Mon, 20 Nov 2017 12:36:47 +0100
- Subject: Re: [patch] Add support for #pragma GCC unroll
- Authentication-results: sourceware.org; auth=none
- References: <3136854.5zjt3GTbhu@polaris> <CAFiYyc1rKGUtEc8MEKetP7=sD6GXs9avKGsY3o0tjF-O1hpT1g@mail.gmail.com>
> Looking at the middle-end changes. The change to ANNOTATE_EXPR to three
> operands is approved also for existing frontends (just in case you
> don't get review).
> Found the missing possibility of an argument limiting myself...
I see. ;-)
> Your changes to the RTL unrolling pass as far as I see enable the
> optimization in its general form for all loops in a function if
> cfun->has_unroll, not just for the marked loops. I think that is
> unintended?
Probably not, let me try and see what can be done.
> I think you want to change copy_loop_info () to copy the flag as well.
The other optimization hints (ivdep, [no-]vector) aren't copied either.
> I think this has the same issue as the RTL unroller change.
Right.
--
Eric Botcazou