This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Do not report non-executed blocks in Ada coverage
- From: Jeff Law <law at redhat dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>, gcc-patches at gcc dot gnu dot org
- Cc: Martin Liška <mliska at suse dot cz>
- Date: Sun, 19 Nov 2017 16:10:27 -0700
- Subject: Re: [patch] Do not report non-executed blocks in Ada coverage
- Authentication-results: sourceware.org; auth=none
- References: <8628973.M8QiBYR5HD@polaris>
On 11/03/2017 05:51 AM, Eric Botcazou wrote:
> Hi,
>
> as explained in
> https://gcc.gnu.org/ml/gcc-patches/2017-11/msg00105.html
> we don't (necessarily) want to report non-executed blocks in Ada.
>
> The couple of attached patches prevent this from happening by detecting
> whether we are dealing with an Ada file; the first variant is optimal, the
> second variant is slightly more general in case other languages need it too.
>
> Tested on x86_64-suse-linux, OK for the mainline (and which one)?
>
>
> 2017-11-03 Eric Botcazou <ebotcazou@adacore.com>
>
> * gcov.c (output_line_beginning): Document HAS_UNEXECUTED_BLOCK.
> (output_lines): Always pass false for HAS_UNEXECUTED_BLOCK to
> above function if this is for an Ada file.
Is this still needed? I know Martin L did another teak for non-executed
blocks in Ada... BUt I don't know enough to determine if it was
sufficient to address this problem.
jeff