This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3 PATCH] Implement LWG 2733 and LWG 2759
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 14 Nov 2017 17:06:57 +0000
- Subject: Re: [v3 PATCH] Implement LWG 2733 and LWG 2759
- Authentication-results: sourceware.org; auth=none
- References: <CAFk2RUY-PDPT7=RZ8uKfrnK4p2-U5-vuebXZA0Kub8dz1yMipA@mail.gmail.com>
On 14/11/17 18:14 +0200, Ville Voutilainen wrote:
Implement LWG 2733 and LWG 2759
* include/experimental/numeric (gcd): Reject cv-qualified bool.
(lcm): Likewise.
* include/std/numeric (gcd): Likewise.
(lcm): Likewise.
* testsuite/26_numerics/gcd/gcd_neg.cc: Add tests and adjust.
* testsuite/26_numerics/lcm/lcm_neg.cc: Likewise.
Both files can use remove_cv_t instead of remove_cv::type (and there's
no need to std-qualify it in std::gcd).
They could also use is_integral_v and is_same_v but that's
pre-existing, and less important because there's no 'typename' that
can be avoided by changing it.