This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA] Implement __VA_OPT__
- From: Jason Merrill <jason at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Alexander Monakov <amonakov at ispras dot ru>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 13 Nov 2017 11:52:48 -0500
- Subject: Re: [RFA] Implement __VA_OPT__
- Authentication-results: sourceware.org; auth=none
- References: <20170916214918.14930-1-tom@tromey.com> <alpine.LNX.2.20.13.1709171224470.23347@monopod.intra.ispras.ru> <87k20xbbq3.fsf@tromey.com> <87bmm9bacr.fsf@tromey.com> <877ewxba8z.fsf@tromey.com> <0811e75e-694c-1760-4960-82dfadee2c36@redhat.com> <87vaigossw.fsf@tromey.com>
On Sun, Nov 12, 2017 at 2:33 AM, Tom Tromey <tom@tromey.com> wrote:
> I'm still [not] too happy with the error message, so if you have any
> suggestions there, please let me know. I removed the "C99" branch from
> the earlier error message as well, since this isn't a C feature at all.
> Again, please check the wording.
I'm ambivalent about mentioning the standard level. And I find the
use of "expansion" in this and the existing __VA_ARGS__ error odd, as
expansion is what you *do* with a macro; I'd prefer "definition".
But I suppose we might as well be consistent with the existing error.
The patch is OK, thanks.
Jason