This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 21/22] Add extra field to gtm_jmpbuf on x86 only


On Tue, Nov 7, 2017 at 8:22 AM, Tsimbalist, Igor V
<igor.v.tsimbalist@intel.com> wrote:
> I decided to split my previous patch "Enable building libitm with Intel CET "
> into two different patches. The first patch will add a new field to sjlj.S and
> target.h  files. The second one will add Intel CET support on the top of the
> first one. In this case the further changes for adding Intel CET support are
> seen clearly.
>
> Ok for trunk?
>

libitm/configure.tgt should check ${target} like the other places:

+# Update libtool_VERSION since the size of struct gtm_jmpbuf is
+# changed for x86.
+case "${host}" in

Did these come from cut and paste?

+  # For x86, we use slots in the TCB head for most of our TLS.
+  # The setup of those slots in beginTransaction can afford to
+  # use the global-dynamic model.

I think the whole thing should be:

case "${target}" in
  # Update libtool_VERSION since the size of struct gtm_jmpbuf is
  # changed for x86.
  i[456]86-*-* | x86_64-*-*)
        libtool_VERSION=2:0:0
        ;;
esac




-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]