This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] RISC-V: Document the medlow and medany code models


I have to disagree.  It's standard to not hyphenate an
adverb-adjective compound, since they tend not to be ambiguous.  But
if the standard in the GCC documentation is to hyphenate, I will not
stand in the way!

On Tue, Oct 31, 2017 at 8:47 PM, Sandra Loosemore
<sandra@codesourcery.com> wrote:
> On 10/31/2017 06:54 PM, Palmer Dabbelt wrote:
>>
>> This documentation is patterned off the aarch64 -mcmodel documentation.
>>
>> gcc/ChangeLog:
>>
>> 2017-10-31  Palmer Dabbelt  <palmer@dabbelt.com>
>>
>>          * doc/invoke.texi (RISC-V Options): Explicitly name the medlow
>>          and medany code models, and describe what they do.
>> ---
>>   gcc/doc/invoke.texi | 17 +++++++++++++----
>>   1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
>> index 43acbcbbcd77..8903afaeeffc 100644
>> --- a/gcc/doc/invoke.texi
>> +++ b/gcc/doc/invoke.texi
>> @@ -989,7 +989,7 @@ See RS/6000 and PowerPC Options.
>>   -msmall-data-limit=@var{N-bytes} @gol
>>   -msave-restore  -mno-save-restore @gol
>>   -mstrict-align -mno-strict-align @gol
>> --mcmodel=@var{code-model} @gol
>> +-mcmodel=medlow -mcmodel=medany @gol
>>   -mexplicit-relocs  -mno-explicit-relocs @gol}
>>
>>   @emph{RL78 Options}
>
>
> Hmmm.  I have a mild preference for keeping the metasyntactic variable in
> the option documentation and using a nested table to list the possible
> values, but I see that the documentation for other backends that support
> this option are not consistent, so I guess it is OK to expand it like that
> as long as you don't anticipate adding additional keywords in the future.
>
>> @@ -21765,9 +21765,18 @@ Use smaller but slower prologue and epilogue
>> code.
>>   @opindex mstrict-align
>>   Do not generate unaligned memory accesses.
>>
>> -@item -mcmodel=@var{code-model}
>> -@opindex mcmodel
>> -Specify the code model.
>> +@item -mcmodel=medlow
>> +@opindex mcmodel=medlow
>> +Generate code for the medium-low code model. The program and its
>> statically
>> +defined symbols must lie within a single 2 GiB address range and must lie
>> +between absolute addresses -2 GiB and +2 GiB. Programs can be statically
>> or
>> +dynamically linked. This is the default code model.
>> +
>> +@item -mcmodel=medany
>> +@opindex mcmodel=medany
>> +Generate code for the medium-any code model. The program and its
>> statically
>> +defined symbols must be within any single 2 GiB address range. Programs
>> can be
>> +statically or dynamically linked.
>>
>>   @end table
>
>
> s/statically defined symbols/statically-defined symbols/g
>
> Bonus points if you make that fix in the aarch64 documentation you copied
> this from, too.  :-)
>
> -Sandra
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]