This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 21/22] Enable building libitm with Intel CET
- From: Jeff Law <law at redhat dot com>
- To: "Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: "triegel at redhat dot com" <triegel at redhat dot com>
- Date: Mon, 30 Oct 2017 17:21:20 -0600
- Subject: Re: [PATCH 21/22] Enable building libitm with Intel CET
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C071AC0587E6
- References: <D511F25789BA7F4EBA64C8A63891A00291F424C6@IRSMSX102.ger.corp.intel.com>
On 10/12/2017 03:21 PM, Tsimbalist, Igor V wrote:
> Enable building libitm with Intel CET options.
>
> libitm/
> * Makefile.in: Regenerate.
> * acinclude.m4: Add enable.m4 and cet.m4.
> * config/x86/sjlj.S
> (_ITM_beginTransaction): Save Shadow Stack pointer.
> (GTM_longjmp): Restore Shadow Stack pointer.
> * config/x86/target.h (struct gtm_jmpbuf):
> Add Shadow Stack pointer.
> * configure: Regenerate.
> * configure.ac: Set CET_FLAGS. Update XCFLAGS, libtool_VERSION.
> * testsuite/Makefile.in: Regenerate.
>
> * config/cet.m4: Define ENABLE_CET_COMPATIBILITY. Set
> enable_cet_compatibility.
>
Would it make sense to avoid having different sizes of gtm_jmpbuf by
simply having the ssp slot always defined, even if we're not using it?
Along the same lines, would it make sense to have that field at the end
of the structure so that the amount of conditional code in in sjlj.S is
minimized (ie, all the offests are the same, so in the CET case you just
have a single extra store).
Jeff