This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, version 5a], Add support for _Float<N> and _Float<N>X sqrt, fma, fmin, fmax built-in functions


On Mon, 30 Oct 2017, Michael Meissner wrote:

> This patch fixes exporting the non __builtin_ names to be done by default only
> for the C language.  I added a target hook in case a port needs to enable
> built-ins for C++ (either wholesale, or for particular built-in functions).

Testing lang_GNU_C () can't possibly be correct here; ObjC should always 
be handled like C unless there is a strong reason not to do so, explicitly 
commented.

Also, I'd expect the FALLBACK_P argument to DEF_BUILTIN to be true, not a 
call to the hook; __builtin_sqrtf128 should always end up generating a 
call to the out-of-line sqrtf128 function if not inlined, regardless of 
source language.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]