This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3 PATCH] Implement LWG 2485
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 30 Oct 2017 14:13:45 +0000
- Subject: Re: [v3 PATCH] Implement LWG 2485
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jwakely at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7264B3B743
- References: <CAFk2RUbfi=CMfbnm4iUyQhqbGjBH-bHyq6qp6E3ZpC=zgFphjg@mail.gmail.com> <CAFk2RUbeHcZEVXp+-Nj7kPh5Ko7WjO869FtVHiVYNGBPTec0KQ@mail.gmail.com>
On 29/10/17 12:46 +0200, Ville Voutilainen wrote:
On 29 October 2017 at 00:57, Ville Voutilainen
<ville.voutilainen@gmail.com> wrote:
2017-10-29 Ville Voutilainen <ville.voutilainen@gmail.com>
Implement LWG 2485
The full testsuite passes on Linux-PPC64. The debug mode tests for
array have been run manually
on Linux-x64.
Looks like there are a couple of Doxygen comments in <tuple> that
don't fit in 80 columns, OK for trunk with those fixed. Thanks.
One solution would be to replace the separate comments on the
different get overloads with a comment group:
/// Return a reference to the ith element of a tuple
/// @{
... define all four overloads
// @}
It seems fairly self-explanatory to me that if the tuple is a const
lvalue the returned reference is const lvalue reference, and if the
tuple is a non-const rvalue the returned tuple is ... blah blah.