This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Edit contrib/ files to download gfortran prerequisites
- From: Jerry DeLisle <jvdelisle at charter dot net>
- To: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>, Damian Rouson <damian at sourceryinstitute dot org>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, gcc patches <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
- Date: Thu, 26 Oct 2017 19:27:26 -0700
- Subject: Re: [Patch] Edit contrib/ files to download gfortran prerequisites
- Authentication-results: sourceware.org; auth=none
- References: <etPan.59c2d116.44baeccc.18c@sourceryinstitute.org> <CAFiYyc2YtEtjP_QC_ux_XU6kVJ69C8QHRt0Q2fDm8U-vuiKBtg@mail.gmail.com> <etPan.59ea941f.46020ae.1c2b@sourceryinstitute.org> <CAC1BbcRsWCQmuPO8+7xx7RE0+cNyxZqPDEA1F9wc0_YWiZdL_Q@mail.gmail.com>
On 10/21/2017 11:17 AM, Bernhard Reutner-Fischer wrote:
> On 21 October 2017 at 02:26, Damian Rouson <damian@sourceryinstitute.org> wrote:
>>
>> Hi Richard,
>>
>> Attached is a revised patch that makes the downloading of Fortran prerequisites optional via a new --no-fortran flag that can be passed to contrib/download_prerequisites as requested in your reply below.
>>
>> As Jerry mentioned in his response, he has been working on edits to the top-level build machinery, but we need additional guidance to complete his work. Given that there were no responses to his request for guidance and it’s not clear when that work will complete, I’m hoping this minor change can be approved independently so that this patch doesn’t suffer bit rot in the interim.
>>
>> Ok for trunk?
>
> + die "Invoking wget and curl in the 'download_prerequisites' script failed."
>
> I suggest "Neither wget nor curl found, cannot download tarballs."
>
> As an open-mpi user i question why this hardcodes MPICH, fwiw.
>
> thanks,
>
Hi Bernhard,
Well, open-mpi does not yet support failed images so we are focusing on mpich.
Maybe what we should do is default to mpich if not otherwise specified and
provide a -mpi=mpich or -mpi=open-mpi, or similar. Then later we can add any
other implementations that show up.
Cheers,
Jerry