This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR81758 - [7/8 Regression] [OOP] Broken vtab
- From: Andre Vehreschild <vehre at gmx dot de>
- To: fortran at gcc dot gnu dot org,Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>,"fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>,gcc-patches <gcc-patches at gcc dot gnu dot org>
- Cc: liakhdi at ornl dot gov,Thomas Koenig <Thomas dot Koenig at online dot de>
- Date: Thu, 26 Oct 2017 21:20:09 +0200
- Subject: Re: [Patch, fortran] PR81758 - [7/8 Regression] [OOP] Broken vtab
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGiKjTNV2fX63tPejvviSMQ1mtN6uHrdY2e5-mb5F_O8Xsg@mail.gmail.com>
Hi Paul,
Without having tested the patch, it looks reasonable to me. So ok from my side.
- Andre
Am 26. Oktober 2017 21:12:45 MESZ schrieb Paul Richard Thomas <paul.richard.thomas@gmail.com>:
>Dear All,
>
>Thanks to Dimitry Liakh for both reporting the problem and doing a lot
>of the diagnostic work. Once the offending line in a very complicated
>code was located, the fix was trivial. Generating a reduced testcase
>took rather longer :-)
>
>The comment in the testcase tells the story. The fix is a one-liner
>that follows immediately from the explanation.
>
>Bootstrapped and regtested on FC23/x86_64 - OK for trunk and 7-branch.
>
>Cheers
>
>Paul
>
>2017-10-26 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/81758
> * trans-expr.c (trans_class_vptr_len_assignment): 'vptr_expr'
> must only be set if the right hand side expression is of class
> type.
>
>2017-10-26 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/81758
> * gfortran.dg/class_63.f90: New test.
--
Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen
Tel.: +49 241 929 10 18 * vehre@gmx.de