This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [libstdc++, patch] Fix build on APFS file system
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: FX <fxcoudert at gmail dot com>
- Cc: Mike Stump <mikestump at comcast dot net>, gcc patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
- Date: Mon, 23 Oct 2017 19:00:40 +0100
- Subject: Re: [libstdc++, patch] Fix build on APFS file system
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jwakely at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 60F864DD49
- References: <1148963B-29B1-48D5-B295-15A5593AC4B9@gmail.com> <C42F9CA6-E8C3-4D95-B7A1-9A33D99E82AF@comcast.net> <55EA1C91-3ADC-4204-837B-4608B73DE2E2@gmail.com>
On 23/10/17 19:48 +0200, FX wrote:
The patch seems like a rough bandaid to hide the real bug. Better to identify the real bug. If there is a missing dependency, then I'd like to think that adding the right dependency should resolve the issue.
So far, apart from a suggestion from Marc, I haven’t received any help or advice in identifying or debugging the issue.
FX
You could try this.
diff --git a/libstdc++-v3/include/Makefile.am b/libstdc++-v3/include/Makefile.am
index 2c4d193d0a4..39083cc4ebc 100644
--- a/libstdc++-v3/include/Makefile.am
+++ b/libstdc++-v3/include/Makefile.am
@@ -1016,6 +1016,8 @@ allcreated = \
# Here are the rules for building the headers
all-local: ${allstamped} ${allcreated}
+${pch_output} : | ${allstamped}
+
# Ignore errors from 'mkdir -p' to avoid parallel make failure on
# systems with broken mkdir. Call mkdir unconditionally because
# it is just as cheap to avoid going through the shell.
diff --git a/libstdc++-v3/include/Makefile.in b/libstdc++-v3/include/Makefile.in
index bc8556c68d2..e1a852e2906 100644
--- a/libstdc++-v3/include/Makefile.in
+++ b/libstdc++-v3/include/Makefile.in
@@ -1465,6 +1465,8 @@ uninstall-am:
# Here are the rules for building the headers
all-local: ${allstamped} ${allcreated}
+${pch_output} : | ${allstamped}
+
# Ignore errors from 'mkdir -p' to avoid parallel make failure on
# systems with broken mkdir. Call mkdir unconditionally because
# it is just as cheap to avoid going through the shell.