This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Do not instrument use-after-scope for vars with large alignment (PR sanitizer/82517).
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, Maxim Ostapenko <m dot ostapenko at samsung dot com>
- Date: Thu, 19 Oct 2017 09:30:55 +0200
- Subject: Re: [PATCH] Do not instrument use-after-scope for vars with large alignment (PR sanitizer/82517).
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 22268820F3
- References: <a7d1efc0-487a-1d15-0129-9836def3c976@suse.cz>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Oct 19, 2017 at 09:21:47AM +0200, Martin Liška wrote:
> Hi.
>
> As discussed with Jakub, use-after-scope sanitization should not be done for variables that have bigger
> alignment than MAX_SUPPORTED_STACK_ALIGNMENT. In this case, we can't put a variable to fixed stack slot.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?
> Martin
>
> gcc/ChangeLog:
>
> 2017-10-18 Martin Liska <mliska@suse.cz>
>
> PR sanitizer/82517
> * gimplify.c (gimplify_decl_expr): Do not instrument variables
> that have a large alignment.
> (gimplify_target_expr): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> 2017-10-18 Martin Liska <mliska@suse.cz>
>
> PR sanitizer/82517
> * gcc.dg/asan/pr82517.c: New test.
Ok, thanks.
Jakub