This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] hash-table for extern-c fns.
On Tue, Oct 10, 2017 at 3:11 PM, Nathan Sidwell <nathan@acm.org> wrote:
> On 10/09/2017 06:15 PM, Nathan Sidwell wrote:
>>
>> On 10/09/2017 11:57 AM, Jason Merrill wrote:
>
>
>>> Hmm, why do we only check extern "C" conflicts for functions?
>>
>>
>> I suspect a bug. I noticed it as existing behaviour and was puzzled the
>> first time around rearranging this code, but didn't want to get distracted
>> from the big picture.
>
>
> This patch checks both vars and fns (as typedefs don't have linkage, I don't
> think they can be extern C, but ICBW).
>
> I also tweaked the diagnostics, so that the first one is a pedwarn and the
> later ones are notes. (so we won't arbitrarily truncate the series of
> diagnostics.
>
> Look good to you?
Yes, thanks.