Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

[Ian Lance Taylor <iant at golang dot org>]

On Fri, Sep 29, 2017 at 7:08 AM, Alex Potapenko <opotapenko@gmail.com> wrote:
> On Fri, Sep 29, 2017 at 4:44 PM, Ian Lance Taylor <iant@golang.org> wrote:
>>
>> Thanks.  Yes, the problem is that -fdump-go-spec is faithfully
>> reporting a dangling type definition, which is fine in C but not in
>> Go.  Since we don't care about any of the locale stuff anyhow, I'm
>> inclined to a patch like the appended.  Can you see if this fixes the
>> problem on your system?  Thanks.
>
>
> After I apply your patch, and additionally patch libgo/mkrsysinfo.sh in the
> similar fashion, it does fix the problem:
>
> --- a/libgo/mkrsysinfo.sh
> +++ b/libgo/mkrsysinfo.sh
> @@ -23,6 +23,7 @@
>    grep -v '^type _timespec_t ' | \
>    grep -v '^type _timespec ' | \
>    grep -v '^type _epoll_' | \
> +  grep -v '^type _*locale[_ ]' | \
>    grep -v 'in6_addr' | \
>    grep -v 'sockaddr_in6' | \
>    sed -e 's/\([^a-zA-Z0-9_]\)_timeval\([^a-zA-Z0-9_]\)/\1timeval\2/g' \

Thanks.  Committed to mainline.

Ian

Attachment: patch.txt
Description: Text document