This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: 0003-Part-3.-Add-tests-for-finstrument-control-flow-and-notrack attribute
- From: Jeff Law <law at redhat dot com>
- To: "Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>, "'gcc-patches at gcc dot gnu dot org'" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 28 Sep 2017 17:08:30 -0600
- Subject: Re: 0003-Part-3.-Add-tests-for-finstrument-control-flow-and-notrack attribute
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DE6634E33B
- References: <D511F25789BA7F4EBA64C8A63891A0027AA0404B@IRSMSX102.ger.corp.intel.com> <06131682-b992-714d-1dc5-8b3801af6674@redhat.com> <D511F25789BA7F4EBA64C8A63891A0028ADB5F5F@irsmsx105.ger.corp.intel.com>
On 09/19/2017 07:58 AM, Tsimbalist, Igor V wrote:
> Here is an updated patch (version #2). Mainly attribute and option names were changed.
> The test for ICF will be introduced in x86 specific tests (patch 0006-Part-6) as the implementation
> checks if the CF instrumentation is on to adjust a hash based on 'nocf'_check' attribute presence.
> In generic part CF instrumentation is off as no implementation exist.
>
> The patch for x86 specific tests (patch 0006-Part-6) is being reviewed by Uros.
>
> gcc/testsuite/
> * c-c++-common/fcf-protection-1.c: New test.
> * c-c++-common/fcf-protection-2.c: Likewise.
> * c-c++-common/fcf-protection-3.c: Likewise.
> * c-c++-common/fcf-protection-4.c: Likewise.
> * c-c++-common/fcf-protection-5.c: Likewise.
> * c-c++-common/attr-nocf-check-1.c: Likewise.
> * c-c++-common/attr-nocf-check-2.c: Likewise.
> * c-c++-common/attr-nocf-check-3.c: Likewise.
>
> Is it ok for trunk?
>
This is OK once the CET changes for the compiler are approved.
Jeff